Repository navigation
Add columns for Custom Field 1 & 2 to the Member tab in Workspace settings - #75242
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Visually looks good for me. cc @dannymcclain for extra eyes |
|
@mohammadjafarinejad can you look into this Codecov report in meanwhile? TY |
Great callout. Yeah let's make it regular text color and size 👍 |
|
@dubielzyk-expensify Updated text styling, new screenshots:
|
|
That looks good to me. |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Looks good to me from a product perspective.
|
Looks good to me too 👍 |
|
Code changes LGTM. @mohammadjafarinejad Unit tests is failing. Can you check if it's caused by our PR? |
|
@hoangzinh Unit test job 4 still isn't finished after 1 hour. Last time it was stuck for 3 hours. I'm unsure if this is related to our PR or the GitHub runner issue. Should I ask in Slack? |
|
Hmm, It doesn't occur in main branch, so probably from our PR. |
|
I can reproduce it in this branch. It looks frozen when I run |
@hoangzinh Thanks! It was caused by |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-24.at.00.01.41.android.movAndroid: mWeb ChromeScreen.Recording.2025-11-23.at.23.58.20.android.chrome.moviOS: HybridAppScreen.Recording.2025-11-24.at.00.07.29.moviOS: mWeb SafariScreen.Recording.2025-11-24.at.00.04.36.ios.safari.movMacOS: Chrome / SafariScreen.Recording.2025-11-23.at.23.51.53.web.movMacOS: DesktopScreen.Recording.2025-11-23.at.23.55.57.desktop.mov |
|
Was out last week for thanksgiving, but looks like there are conflicts now |
|
@thienlnam Ready for review |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 9.2.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀
|
| <View style={[StyleUtils.getMinimumWidth(variables.w72)]}> | ||
| <MemberRightIcon | ||
| role={policyEmployee.role} | ||
| owner={policy?.owner} | ||
| login={details.login} | ||
| /> |
There was a problem hiding this comment.
Adding minWidth here caused minor style regression.
More details: #79341 (comment)






Explanation of Change
Adds Custom Field 1 and Custom Field 2 columns to the Workspace Members tab, allowing admins to view this information directly in the list.
Fixed Issues
$ #74416
PROPOSAL: #74416 (comment)
Tests
Open the Workspace Members tab in a Control Plan workspace.
Verify the list matches the design mocks in the issue, including columns for Member, Custom Field 1, Custom Field 2, and Role.
Open the Workspace Members tab in a Collect Plan workspace and verify that the Custom Field 1 and Custom Field 2 columns are not displayed.
Offline tests
Same as test.
QA Steps
Same as test.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
FIX_ANDROID.mp4
Android: mWeb Chrome
FIX_ANDROIDWEB.mp4
iOS: Native
FIX_IOS.mp4
iOS: mWeb Safari
FIX_IOSWEB.mp4
MacOS: Chrome / Safari
FIX_WEB.mp4
MacOS: Desktop
FIX_DESKTOP.mp4